Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up work after new on-the-fly attribute generation #57

Closed
9 tasks done
mchakravarty opened this issue Apr 3, 2023 · 0 comments
Closed
9 tasks done

Clean up work after new on-the-fly attribute generation #57

mchakravarty opened this issue Apr 3, 2023 · 0 comments

Comments

@mchakravarty
Copy link
Owner

mchakravarty commented Apr 3, 2023 •
edited
Loading

  • Bracket matching with new architecture
  • Automatic bracket insertion/deletion with new architecture
  • In some cases, there still seems to be a line map update problem (e.g., when deleting and re-inserting a line or so)
  • Gutter redraw needs to be triggered by actual layout change and not whenever layout() is called
  • Minimap is not drawn before scrolling a bit
  • Scroll to bottom after (some) character insertion or deletion
  • Scroll jumps on redraw
  • Initial drawing of the gutter and minimap has a delay on larger files
  • Scroll position is incorrect on restore (restart) — at least for long files
@mchakravarty mchakravarty changed the title Clean up work Clean up work after new on-the-fly attribute generation Apr 3, 2023
mchakravarty added a commit that referenced this issue May 1, 2023
@mchakravarty
Revamp token handling and tiling
b5ab979 
We don’t store tokens and comment attributes in the `NSMutableAttributedString` of `NSTextStorage` anymore. Instead, we maintain that information as part of the line map and synthesise attribute information (e.g., for syntax highlighting) on the fly.

We are also more careful with tiling (on macOS) to avoid invalidating information and triggering recomputes or redraws.

Contributes to #24, #29, #13, and #57
mchakravarty added a commit that referenced this issue May 1, 2023
@mchakravarty
Persist absolute scroll position, not fraction
2a72521 
Persisting the fraction was a misfeature, as it is dependent on the text length.

Contributes to #57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
CodeEditorView Release 1.0
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mchakravarty