Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer spacings is broken #49

Open
AmrAbdulrahman opened this issue Oct 5, 2018 · 0 comments
Open

Footer spacings is broken #49

AmrAbdulrahman opened this issue Oct 5, 2018 · 0 comments

Comments

@AmrAbdulrahman
Copy link
Contributor

AmrAbdulrahman commented Oct 5, 2018

The footer has two UI issues:

  1. It has extra spacing at the bottom

screen shot 2018-10-05 at 15 03 03

  1. The badges box has top and bottom extra spacings

screen shot 2018-10-05 at 15 03 16

To fix this, find following the code:

.footer .all-rights-reserved {
  padding: 0 20px;
}

@include respond-to('tablet') {
  .footer .imprint {
    padding: 20px!important;
  }

  .footer .imprint .column {
    margin: 0!important;
  }

  .footer__card__badges {
    padding-top: 8px; // this should be a grid variable
    padding-bottom: 8px;
  }
}

@include respond-to('desktop') {
  .footer__card__header {
    margin-left: 0;
  }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants