Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to disable the key #166

Merged
merged 3 commits into from
Jan 6, 2023
Merged

Option to disable the key #166

merged 3 commits into from
Jan 6, 2023

Conversation

tradiff
Copy link
Contributor

@tradiff tradiff commented Dec 23, 2022

Closes #165

  • Add an option to disable the key. This can be useful if trying to save real estate, and you're already familiar with the colors and symbols in the diff.
  • Add documentation for the Elision feature.

mcmire
mcmire reviewed Dec 29, 2022
View reviewed changes
Copy link
Collaborator

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey sorry for the delayed review! This looks pretty good, thanks for adding this and also backfilling the README. I just had a few suggestions.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
spec/integration/rspec/eq_matcher_spec.rb Outdated Show resolved Hide resolved
@tradiff tradiff requested a review from mcmire December 29, 2022 21:31
@tradiff
Copy link
Contributor Author

tradiff commented Jan 6, 2023

@mcmire reminder about this PR when you get a chance!

@mcmire
Copy link
Collaborator

mcmire commented Jan 6, 2023

Looks great! CI is failing, but I'm not sure why, and it seems unrelated anyway. Thanks so much!

@mcmire mcmire merged commit 39c52af into splitwise:master Jan 6, 2023
@tradiff tradiff deleted the disable-key branch July 9, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire Awaiting requested review from mcmire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to disable the key (legend)
2 participants
@tradiff @mcmire