We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In document of method additionalResourcesLocator it says:
additionalResourcesLocator
Rules: The Strings in the set must not end with ".class". Conflicts with other ITransformationServices will result in an immediate crash.
But inside TransformationServiceDecorator, it checks the name with this logic:
final Set<String> badResourceNames = resNames.stream(). filter(s -> !s.endsWith(".class") || resourceNames.contains(s)). collect(Collectors.toSet());
It seems inverted to me. Am I getting something wrong?
The text was updated successfully, but these errors were encountered:
Yes, I believe you are.
Sorry, something went wrong.
No he is right, this check is the wrong way around, this crashes if a resource does not end with .class
Fix inverted test. Closes #40 properly
98feda0
Signed-off-by: cpw <cpw+github@weeksfamily.ca>
No branches or pull requests
In document of method
additionalResourcesLocator
it says:But inside TransformationServiceDecorator, it checks the name with this logic:
It seems inverted to me. Am I getting something wrong?
The text was updated successfully, but these errors were encountered: