Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added unsubscribe function in client #127

Merged
merged 3 commits into from
Jul 14, 2017
Merged

added unsubscribe function in client #127

merged 3 commits into from
Jul 14, 2017

Conversation

GavinDmello
Copy link
Collaborator

I just used the PR related to https://github.com/mcollina/aedes/issues/114
Let me know if a test case is needed

@coveralls
Copy link

coveralls commented Jul 13, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.7%) to 96.731% when pulling 2a607ea on handleUnsubscribe into 3ba632a on master.

@mcollina
Copy link
Collaborator

Yes it is :)

@coveralls
Copy link

coveralls commented Jul 13, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 97.474% when pulling b5fdf35 on handleUnsubscribe into 3ba632a on master.

@mcollina
Copy link
Collaborator

Can you add it to the docs?

@GavinDmello
Copy link
Collaborator Author

Sure.

@coveralls
Copy link

coveralls commented Jul 14, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 97.474% when pulling 7132bd3 on handleUnsubscribe into 3ba632a on master.

@mcollina mcollina merged commit ac1c8ea into master Jul 14, 2017
@mcollina mcollina deleted the handleUnsubscribe branch July 14, 2017 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GavinDmello @coveralls @mcollina