-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests #340
Fix tests #340
Conversation
@mcollina Tests are broken on nodejs 12, don't know why as I didn't change anything in those tests. I think something has changed between nodejs 10 to 12 maybe something related to timers |
@robertsLando can you send a PR to fix those tests? |
@robertsLando they are fixed in my previous PR you can check at it ( proxy and ip decoder ). |
@mcollina Could you merge that PR so? I think everything has been resolved on that. |
@robertsLando If it's about connDetails initialization, it was solved in the last commit, i forgot to resolve the discussion. |
I do not have a clue which PR we are talking about. |
No description provided.