Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #340

Closed
wants to merge 4 commits into from
Closed

Fix tests #340

wants to merge 4 commits into from

Conversation

robertsLando
Copy link
Member

No description provided.

@robertsLando
Copy link
Member Author

robertsLando commented Dec 9, 2019

@mcollina Tests are broken on nodejs 12, don't know why as I didn't change anything in those tests. I think something has changed between nodejs 10 to 12 maybe something related to timers

@mcollina
Copy link
Collaborator

@robertsLando can you send a PR to fix those tests?

@robertsLando
Copy link
Member Author

@mcollina Sorry I really have no idea where to start with them, as I said I haven't change anything to break them... May @gnought help?

@getlarge
Copy link
Member

getlarge commented Dec 16, 2019

@robertsLando they are fixed in my previous PR you can check at it ( proxy and ip decoder ).

@robertsLando
Copy link
Member Author

@mcollina Could you merge that PR so? I think everything has been resolved on that.

@robertsLando
Copy link
Member Author

@getlarge You still have a request to resolve, please fix it so @mcollina can merge your PR :)

@getlarge
Copy link
Member

@robertsLando If it's about connDetails initialization, it was solved in the last commit, i forgot to resolve the discussion.

@robertsLando
Copy link
Member Author

@getlarge Maybe he was waiting for that, hope @mcollina will merge your PR soon so I will merge it with mine to fix the tests.

@mcollina
Copy link
Collaborator

I do not have a clue which PR we are talking about.

@robertsLando
Copy link
Member Author

@mcollina #334

@mcollina
Copy link
Collaborator

mcollina commented Dec 16, 2019 via email

@robertsLando
Copy link
Member Author

All my changes where included in the PR just merged so I will close this. Thanks @getlarge @mcollina. Will you release e new version with latest changes?

This was referenced Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants