Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit an event when the server receives a ping #75

Merged
merged 2 commits into from
Oct 25, 2016
Merged

Emit an event when the server receives a ping #75

merged 2 commits into from
Oct 25, 2016

Conversation

renatoc
Copy link
Contributor

@renatoc renatoc commented Oct 25, 2016

No description provided.

@coveralls
Copy link

coveralls commented Oct 25, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 97.063% when pulling aa4a3eb on renatoc:master into 8ad3734 on mcollina:master.

mcollina
mcollina requested changes Oct 25, 2016
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a unit test for this?

@renatoc
Copy link
Contributor Author

renatoc commented Oct 25, 2016

@mcollina Yes, i will do that.

@coveralls
Copy link

coveralls commented Oct 25, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 97.063% when pulling 9536f9a on renatoc:master into 8ad3734 on mcollina:master.

mcollina
mcollina approved these changes Oct 25, 2016
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

@mcollina mcollina merged commit 9771fd7 into moscajs:master Oct 25, 2016
@renatoc
Copy link
Contributor Author

renatoc commented Oct 25, 2016

@mcollina Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@renatoc @coveralls @mcollina