Exception should not be used for CustomErrors, replacing it with StandardError #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dardError Please don't use Exception for application errors, it can't be rescued in a normal catch block... See here for best practices: https://www.honeybadger.io/blog/ruby-exception-vs-standarderror-whats-the-difference/
|
Would be great if anyone take a look at this PR and merge it if it's fine? |
|
Is there any chance this PR gets accepted? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please don't use Exception for application errors, it can't be rescued in a normal catch block...
See here for best practices: https://www.honeybadger.io/blog/ruby-exception-vs-standarderror-whats-the-difference/