Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spurious failure in some dos-expansion related unit tests #167

Open
tkittel opened this issue Mar 5, 2024 · 1 comment
Open

Spurious failure in some dos-expansion related unit tests #167

tkittel opened this issue Mar 5, 2024 · 1 comment
Labels
bug tests unit tests and CI setup

Comments

@tkittel
Copy link
Member

tkittel commented Mar 5, 2024

In the ncrystaldev repo (and thus in the simple-build-dgcode CI) we have several unit tests that fail on osx due to tiny floating-point variations between macos and linux (or, clang vs. gcc?). Although it would be great to figure out the cause of these discrepancies, it is likely that this is simply a feature of floating point irreproducibilities, and we should at least make the unit tests more robust so that they do not flag issues that are irrelevant.

For reference, here is how I am currently avoiding these tests on osx:

           if [ "$RUNNER_OS" == "macOS" ]; then
             export tmp="${tmp}"',!sb_nclongextratests_testdosplot'
             export tmp="${tmp}"',!sb_nclongextratests_testplots2'
             export tmp="${tmp}"',!sb_nclongtests_testloadvdos'
             export tmp="${tmp}"',!sb_nclongtests_testrange'
             export tmp="${tmp}"',!sb_nclongtests_vdosloaddbg'
           fi                                                                                                                                                                                          
           sb -t --testexcerpts=100 --testfilter="{$tmp}" 
@tkittel tkittel added bug tests unit tests and CI setup labels Mar 5, 2024
@tkittel
Copy link
Member Author

tkittel commented Mar 5, 2024

Once fixed, we should reenable the tests in simple-build-dgcode's condatest_essncrystaldev.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug tests unit tests and CI setup
Projects
None yet
Development

No branches or pull requests

1 participant