Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDBCollapse keep height after animation ends #175

Closed
JasperHorn opened this issue May 22, 2023 · 2 comments
Closed

MDBCollapse keep height after animation ends #175

JasperHorn opened this issue May 22, 2023 · 2 comments

Comments

@JasperHorn
Copy link

In plain mdb, the height of the component is removed after the animation has ended. In react-mdb, the height of the component remains after the animation.

The mdb-react approach means that if you change the content of the collapsible element, it may overflow or not shrink to fit the content. Additionally, the documentation shows the react code on top of a sample that is (apparently) not running the react code, so differences in behavior have a very misleading representation in the documentation...

See these examples:

No react: https://stackblitz.com/edit/github-ceeupc-jos1xg?file=index.html
React: https://stackblitz.com/edit/github-ceeupc-xnziba?file=src%2FApp.tsx

In both examples, open the collapsible comment and then click the "add content" button to double the content of the collapsible item. The red div is added so you can see where the other div is overflowing.

@gbujanski
Copy link
Member

Thanks for reporting. We will fix it as soon as possible.

@mako3577
Copy link
Contributor

Fixed in 6.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants