Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

At html4-entities, yuml is repeated twice instead of distinguish between yuml and Yuml #20

Closed
hwangar opened this issue Nov 30, 2016 · 6 comments

Comments

@hwangar
Copy link

hwangar commented Nov 30, 2016

Same happens with dagger

@hwangar
Copy link
Author

hwangar commented Dec 1, 2016

... and same with all uppercase greek letters
(sorry for being a PITA :P)

@mdevils
Copy link
Owner

mdevils commented Dec 1, 2016

Hello @hwangar, can you please provide a short code demonstrating the problem?

@hwangar
Copy link
Author

hwangar commented Dec 1, 2016

Of course:
`
var Entities = require('html-entities'). Html4Entities;
var entities = new Entities();

var raw='Ÿ†‡ ΑΒΓΔΕΖΗΘΙΚΛΜΝΞΟΠΡΣΤΥΦΧΨΩ';
assert.equal(entities.decode(entities.encodeNonUTF(raw)), raw);
`

If you look at html4-entities.js, symbols for yuml, dagger and greek's are duplicated (same for lowercase than for uppercase), hence the error

@hwangar
Copy link
Author

hwangar commented Dec 1, 2016

′ is duplicated too

@hwangar
Copy link
Author

hwangar commented Dec 1, 2016

I fixed the file as I found typos, do you want me to attach the fixed html4 js?

@dan1wang
Copy link

fixed on 2017-04-01 by Karman Kertesz. Please close this issue.

@mdevils mdevils closed this as completed Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants