Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output label overlays output #743

Closed
wbamberg opened this issue Mar 31, 2022 · 4 comments
Closed

Output label overlays output #743

wbamberg opened this issue Mar 31, 2022 · 4 comments

Comments

@wbamberg
Copy link
Collaborator

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/progress

Screen Shot 2022-03-30 at 6 48 17 PM

@NiedziolkaMichal
Copy link
Member

I have checked all HTML examples and those are pages with the same problem on firefox:
div, figcaption, figure, caption, col, colgroup, table, tbody, td, tfoot, th, thead, tr, details, summary, email, number, time, week, area, img, track, video, style, fieldset, form, legend, iframe, object, picture, article, header.

Most pages have parapraph or a heading at the top, which provides additional top margin and there is no overlapping. However if there is an image, table, div, label, form, video or few other similar elements, content may be partially hidden by "OUTPUT". How about adding padding-top to .output, to lower every example by just a little bit?

image

@wbamberg
Copy link
Collaborator Author

Thanks for doing this analysis @NiedziolkaMichal ! Yes, it looks like that could work. I wonder if we even need the output label.

@NiedziolkaMichal
Copy link
Member

CSS and JS examples don't have such label. I think deleting it might also be a good solution:
image

image

@NiedziolkaMichal
Copy link
Member

Fixed by #820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants