Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with "Regular expression syntax cheatsheet": … #1737

Closed
ColinEberhardt opened this issue Jan 25, 2021 · 1 comment · Fixed by #1808
Closed

Issue with "Regular expression syntax cheatsheet": … #1737

ColinEberhardt opened this issue Jan 25, 2021 · 1 comment · Fixed by #1808
Assignees
Labels
Content:JS JavaScript docs

Comments

@ColinEberhardt
Copy link

MDN URL: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_Expressions/Cheatsheet

What information was incorrect, unhelpful, or incomplete?

The MDN cheat sheet uses the term character set to describe the concept that almost all other regex documentation refers to as characters classes

Specific section or headline?

"Character classes"

What did you expect to see?

If you check other sources for regex reference, the regex of the form [xyz], [a-c] are termed character classes. See for example:

https://www.regular-expressions.info/refcharclass.html
TC49 tests: https://github.com/tc39/test262/blob/master/test/built-ins/RegExp/regexp-class-chars.js#L9

However, the MDN cheat sheet calls these character sets

Did you test this? If so, how?

MDN Content page report details
@Elchi3
Copy link
Member

Elchi3 commented Jan 27, 2021

Given we call it Character Classes here https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_Expressions/Character_Classes and Character set is easily to be confused with the same term used in encoding (https://developer.mozilla.org/en-us/docs/Glossary/character_set), I'm going to change this.

Thanks for your report!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:JS JavaScript docs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants