Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebAPI] ship beforeinput event and InputEvent.getTargetRanges() #2511

Closed
chrisdavidmills opened this issue Feb 19, 2021 · 5 comments
Closed
Assignees
Labels
Content:WebAPI Web API docs fx release archive A closed issue relating to firefox release notes for developers.

Comments

@chrisdavidmills
Copy link
Contributor

chrisdavidmills commented Feb 19, 2021

Acceptance criteria

    • The listed features are documented sufficiently on MDN
    • BCD is updated
    • Interactive example and data repos are updated if appropriate
    • The content has been reviewed as needed

Features to document

  1. beforeinput event and InputEvent.getTargetRanges()

Related Gecko bugs

We've already got these documented, so should be easy — BCD update, rel note, possibly remove experimental features entry?

For folks helping with Firefox-related documentation features — make sure above AC have been done, but also:

  • Set bugs to dev-doc-complete
  • Add entry to Firefox release notes if feature is enabled in release
  • Add entry to Firefox experimental features page if feature is not yet enabled in release
@Rumyra
Copy link
Collaborator

Rumyra commented Feb 24, 2021

Personal todo:

  • Check docs
  • BCD
  • Release notes

@Rumyra Rumyra self-assigned this Feb 24, 2021
@Rumyra
Copy link
Collaborator

Rumyra commented Feb 24, 2021

Ha - so... I have BCD all ready to go, however this is still behind the pref for me in both 87 & 88. Have I misunderstood and it's still behind a pref, it will just be released in 87?

Both https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/beforeinput_event and https://developer.mozilla.org/en-US/docs/Web/API/InputEvent/getTargetRanges are up to date.

BCD is up to date

I'm not sure what this means in regards to both BCD and release notes @chrisdavidmills -> I'm going to add to release notes as per comments here https://bugzilla.mozilla.org/show_bug.cgi?id=1665530#c7

Removed from experimental and added to release - plus a sentence as per above comment:

#2939

@chrisdavidmills
Copy link
Contributor Author

Hi @Rumyra ! Finally getting round to doing my reviews of this stuff.

On this one, I noticed that the BCD hasn't been updated. Since it is shipped in 87, both data points should be updated. Can you do that asap please? Thanks!

@Rumyra
Copy link
Collaborator

Rumyra commented Mar 16, 2021

So sorry @chrisdavidmills !

See mdn/browser-compat-data#9481

@chrisdavidmills
Copy link
Contributor Author

No worries! Now we've got the BCD in, we can close...

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022
@bsmth bsmth added fx release archive A closed issue relating to firefox release notes for developers. and removed Firefox 87 labels Dec 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:WebAPI Web API docs fx release archive A closed issue relating to firefox release notes for developers.
Projects
None yet
Development

No branches or pull requests

3 participants