Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intl.Locale info getters changed to methods #26288

Closed
Josh-Cena opened this issue Apr 19, 2023 · 6 comments
Closed

Intl.Locale info getters changed to methods #26288

Josh-Cena opened this issue Apr 19, 2023 · 6 comments
Labels
Content:JS JavaScript docs

Comments

@Josh-Cena
Copy link
Member

Josh-Cena commented Apr 19, 2023

MDN URL

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Locale

What information was incorrect, unhelpful, or incomplete?

The mention of the following getters:

calendars, collations, hourCycles, numberingSystems, timeZones, textInfo, weekInfo.

What did you expect to see?

They have been changed into methods: tc39/proposal-intl-locale-info#67

The spec URLs have been removed in BCD: mdn/browser-compat-data#19392

Do you have any supporting links, references, or citations?

This change has been implemented in JSC: WebKit/WebKit#10241

V8 bug: https://bugs.chromium.org/p/v8/issues/detail?id=13835&q=locale%20info&can=2

SpiderMonkey doesn't implement the locale-info proposal yet.

Do you have anything more you want to share?

No response

@Josh-Cena Josh-Cena added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Apr 19, 2023
@github-actions github-actions bot added the Content:JS JavaScript docs label Apr 19, 2023
@Josh-Cena Josh-Cena removed the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Apr 19, 2023
@OnkarRuikar
Copy link
Contributor

We have to keep the property pages as it is till two years after all the browsers drop support. [ref]

Instead we need to create new pages for methods. And put warnings on property pages saying use methods now.

@Josh-Cena
Copy link
Member Author

Josh-Cena commented Apr 19, 2023

Yes, that's the plan I think. Can't remove them :/

@teoli2003
Copy link
Contributor

An alternative is to keep one page and say they are methods, but some browsers implement them as properties (and once all have updated their implementation, only keep it into bcd.

@Josh-Cena
Copy link
Member Author

Josh-Cena commented Apr 21, 2023

Not sure what I should do: redirect, or new pages? I am leaning to redirects because more pages is more trouble. Just want to make sure that everyone's comfortable with this—if so, the BCD will be changed by moving the feature and adding a note saying in certain versions it's implemented under the alternative name as an accessor property.

@Elchi3
Copy link
Member

Elchi3 commented Apr 21, 2023

I am leaning to redirects because more pages is more trouble. Just want to make sure that everyone's comfortable with this—if so, the BCD will be changed by moving the feature and adding a note saying in certain versions it's implemented under the alternative name as an accessor property.

I'm comfortable with this and I think we have acted similar on previous cases like this.

@Josh-Cena
Copy link
Member Author

This should be fixed now

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:JS JavaScript docs
Projects
None yet
Development

No branches or pull requests

4 participants