Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the PWA Badging How-To page based on a new WebKit blog #26430

Closed
captainbrosset opened this issue Apr 26, 2023 · 1 comment · Fixed by #26586
Closed

Update the PWA Badging How-To page based on a new WebKit blog #26430

captainbrosset opened this issue Apr 26, 2023 · 1 comment · Fixed by #26586
Labels
needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.

Comments

@captainbrosset
Copy link
Contributor

MDN URL

https://developer.mozilla.org/en-US/docs/Web/Progressive_web_apps/How_to/Display_badge_on_app_icon

What specific section or headline is this issue about?

No response

What information was incorrect, unhelpful, or incomplete?

The WebKit team recently published a very useful blog post about bading on iOS: https://webkit.org/blog/14112/badging-for-home-screen-web-apps/

Reading through it made me realize that I had missed an important aspect in this new PWA How-to page on MDN: that notification permission is required before being able to use the badging API.

We should go back and edit the page to add this information in.

@marcoscaceres by any chance, would you be interested in taking on this issue? If not, I'll eventually get to it, but it might be some time before I do.
Of course, anyone else is more than welcome to work on this!

What did you expect to see?

Information that user permission is required, and how to request it.

Do you have any supporting links, references, or citations?

https://webkit.org/blog/14112/badging-for-home-screen-web-apps/

Do you have anything more you want to share?

No response

MDN metadata

Page report details
@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Apr 26, 2023
@kevinctofel
Copy link
Contributor

kevinctofel commented Apr 26, 2023

I’d like to work on this as a first-timer and dev in training. I’ll start working on my PR today if this is acceptable. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants