-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JS] Ship ArrayBuffer.prototype.transfer proposal #31101
Comments
This ships the Status
|
Does MDN link to polyfills on npm for production use? If so, I'd love to see https://npmjs.com/arraybuffer.prototype.transfer, https://www.npmjs.com/package/arraybuffer.prototype.transfertofixedlength, and https://www.npmjs.com/package/arraybuffer.prototype.detached listed. |
Yes, but we typically only link to core-js because that one is integrated with Babel by default and thus most widely used. Unless other polyfills have significant advantages I don't think we want to have multiple links since it isn't our main goal to be exhaustive about polyfills. I see that we are lacking core-js links here so maybe I would check that later. |
Ah, I see @zloirock already pointed that out in #31213 (comment); all good :) |
Also, we are cautious with linking to external polyfills as they are a security risk: the owner of the external link can change the code. That's another reason why we link mainly to core-js or w3c polyfills. (The risk is not 0, but lower: if one of the two becomes problematic, the word will spread quickly, and we can monitor the situation.) |
Fair, but only linking to core-js is “picking a winner”, and i think my es-shims packages are a bit less of a security risk (or at least, no more) for a number of reasons. In other words, i think it’s reasonable to ask that you list zero everywhere, or more than one everywhere. |
I trust you and es-shims, but there's no reason to not trust core-js, and after all, core-js is used by default in Babel, which means more people unconsciously rely on it. After all, it is my opinion that one should never explicitly care about environment compatibility—configure the target and let toolings handle the rest. |
@Josh-Cena thats a fine reason to have included it so far, but i don’t think it’s a reason to only include it. |
I am not spot adding es-shims as part of this work. Listing a single defacto standard option is how MDN avoids maintaining lists of things that regularly go out of date. I agree selecting corejs or any other option for this is self-reinforcing and that is a bit unfair. Just having one option is better for both users and for the MDN team though. Otherwise where do we draw the line? If you want to continue this discussion then please create a discussion https://github.com/orgs/mdn/discussions with reasons why it would be better for users to have this option and why it is worth the maintenance cost to MDN. I expect you would need to add the links if agreed they are permitted. Note that the MDN does maintain the links in that we remove them once there is full/near full support across browsers, even if there is no great historical depth. |
@hamishwillee sure, that's fair, altho prior to the reorg, when it was a wiki, there were a number of es-shims links, because i put them there years ago - so someone must have removed them. |
@hamishwillee filed https://github.com/orgs/mdn/discussions/475, in which I reject your logical fallacy argument and point out that it is more choices that is better for users, which is why Mozilla and Firefox themselves exist. |
@ljharb Thanks. My argument is misrepresented - from MDN point of view it's more about whether we can maintain having multiple choices, and whether the benefit of offering those choices is worth the cost of that maintenance to MDN - and to users if we fail and the information rots. I've responded to that effect in your linked item. I'm hoping @Josh-Cena, @teoli2003 and others will weigh in on the technical merits there. Josh's view in particular "counts" since he is doing most of the maintenance in the JavaScript area. |
All of the linked tasks for this issue are resolved, so I'm closing this as done now. Thank you! |
Acceptance Criteria
For folks helping with Firefox related documentation
dev-doc-complete
Related Gecko bugs
https://bugzilla.mozilla.org/show_bug.cgi?id=1865103
Other
The text was updated successfully, but these errors were encountered: