Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with "<button>: The Button element": onClick global not listed #7460

Closed
ShrimpTacos314 opened this issue Jul 30, 2021 · 5 comments
Closed
Labels
Content:HTML Hypertext Markup Language docs

Comments

@ShrimpTacos314
Copy link

MDN URL: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button

What information was incorrect, unhelpful, or incomplete?

It appears you forgot to list the "onClick" attribute.

Specific section or headline?

Under the "Attributes" heading.

What did you expect to see?

The "onClick" attribute

Did you test this? If so, how?

How are you supposed to test the absence of content?

MDN Content page report details
@Ryuno-Ki
Copy link
Collaborator

Hey @ShrimpTacos314,

onclick (it's not React where it would be onClick) is a global attribute.
Thus, you would need to follow the link under https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#attributes to get there.

A button element is not the only element that can receive it.

Thank you for the taking the time to report this issue. I'm going ahead and close this.
I encourage you to continue if you have questions.

@Ryuno-Ki Ryuno-Ki added the Content:HTML Hypertext Markup Language docs label Jul 30, 2021
@ShrimpTacos314
Copy link
Author

ShrimpTacos314 commented Aug 3, 2021

Uhhhhh, that's the same page. onClick isn't there.

@ShrimpTacos314 ShrimpTacos314 changed the title Issue with "<button>: The Button element": (short summary here please) Issue with "<button>: The Button element": onClick global not listed Aug 3, 2021
@Ryuno-Ki
Copy link
Collaborator

Ryuno-Ki commented Aug 3, 2021

This element's attributes include the global attributes.

It's a global attribute and thus not listed.

@ShrimpTacos314
Copy link
Author

Okay, that makes more sense. But as a beginner to the site, I was confused... maybe tweak that a bit??

@Ryuno-Ki
Copy link
Collaborator

Ryuno-Ki commented Aug 4, 2021

I encourage you to open a new discussion for this:
https://github.com/mdn/content/discussions

Issues are used in this project for changes on content. General directions are first discussed in a discussions thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:HTML Hypertext Markup Language docs
Projects
None yet
Development

No branches or pull requests

2 participants