Added an example for String.length #1080
Conversation
There was a problem hiding this comment.
Thanks @irenesmith .
Just some formatting nits. But I also thought, since this is a short example, it might be worth including something a bit more advanced, like:
// Some characters are represented using 2 UTF-16 code units
var grinningFace = '😀';
console.log(grinningFace.length);
// expected output: "2"
| <code id="static-js">const str='Life, the universe and everything. Answer:'; | ||
| console.log(str + ' ' + str.length); // 42 | ||
| </code> | ||
| </pre> |
There was a problem hiding this comment.
Please end files with a newline.
| @@ -0,0 +1,5 @@ | |||
| <pre> | |||
| <code id="static-js">const str='Life, the universe and everything. Answer:'; | |||
There was a problem hiding this comment.
Stick with ES5 for ES5 examples (https://github.com/mdn/interactive-examples/blob/master/JS-Example-Style-Guide.md#language-choice-es5es6) - this means using var here.
There was a problem hiding this comment.
Also please use spaces for readability: var str = '...
| @@ -0,0 +1,5 @@ | |||
| <pre> | |||
| <code id="static-js">const str='Life, the universe and everything. Answer:'; | |||
| console.log(str + ' ' + str.length); // 42 | |||
There was a problem hiding this comment.
Please use the standard expected output: format.
There was a problem hiding this comment.
Thanks @irenesmith ! Still a couple of nits to fix here. Also, what did you think of the suggestion to also use an emoji character, to show that length is actually giving us UTF-16 units, not necessarily characters?
| @@ -0,0 +1,7 @@ | |||
| <pre> | |||
| <code id="static-js">const str = 'Life, the universe and everything. Answer:'; | |||
There was a problem hiding this comment.
This should be var not const.
|
You should be picky. Don't know why I said the wrong thing. Resolved both of these comments. |
| <code id="static-js">var str = 'Life, the universe and everything. Answer:'; | ||
|
|
||
| console.log(str + ' ' + str.length); | ||
| // expected output: 42 |
There was a problem hiding this comment.
expected output should be "Life, the universe and everything. Answer: 42"
There was a problem hiding this comment.
Looks great, thanks @irenesmith . I thought more about the emoji example and decided to omit it, let's keep things simple. But I did make the editor shorter, since this is such a small example.
* upstream/master: (36 commits) Adds h1-h6 example (mdn#1180) chore(deps): update dependency eslint to v5.7.0 (mdn#1181) chore(deps): update dependency ajv to v6.5.4 (mdn#1178) chore(deps): pin dependency mdn-bob to 1.1.16 (mdn#1177) Removing some folders that was leftover (mdn#1179) Issue#1005 web api examples editor (mdn#1142) (mdn#1174) chore(deps): update dependency husky to v1.1.1 (mdn#1173) chore(deps): update dependency puppeteer to v1.9.0 (mdn#1172) Adding an example for the String.toString() method (mdn#1076) Adding method for String.valueOf() method (mdn#1078) Added an example for String.length (mdn#1080) Clarifying Promise.resolve() Example (mdn#1125) Remove background from datalist example (mdn#1099) Remove background from option example (mdn#1102) Removed background image from optgroup (mdn#1101) Update <img> to use CC0 image (mdn#1087) use `+=` instead of `a = a + x` (mdn#1171) chore(deps): update dependency husky to v1.1.0 (mdn#1168) chore(deps): update dependency eslint to v5.6.1 (mdn#1167) chore(deps): update dependency stylelint to v9.6.0 (mdn#1165) ...
No description provided.