Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use += instead of a = a + x #1171

Merged
merged 1 commit into from Oct 3, 2018
Merged

use += instead of a = a + x #1171

merged 1 commit into from Oct 3, 2018

Conversation

ghost
Copy link

@ghost ghost commented Oct 3, 2018

No description provided.

@welcome
Copy link

welcome bot commented Oct 3, 2018

💖 Thanks for opening this pull request! 💖
Here is a list of things that will help get it across the finish line:

  • If this is a new or updated CSS interactive example, please ensure that you followed the CSS styleguide - If this is a new or updated JavaScript interactive example, please ensure that you followed the JavaScript styleguide - If your changes affects any of the steps in our contribution docs, please also make the relevant changes there.

Copy link
Contributor

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. Thanks @Flatllin !

@wbamberg wbamberg merged commit 664d986 into mdn:master Oct 3, 2018
@welcome
Copy link

welcome bot commented Oct 3, 2018

Congrats on merging your first pull request! 🎉🎉🎉

wbamberg pushed a commit to wbamberg/interactive-examples that referenced this pull request Oct 16, 2018
* upstream/master: (36 commits)
  Adds h1-h6 example (mdn#1180)
  chore(deps): update dependency eslint to v5.7.0 (mdn#1181)
  chore(deps): update dependency ajv to v6.5.4 (mdn#1178)
  chore(deps): pin dependency mdn-bob to 1.1.16 (mdn#1177)
  Removing some folders that was leftover (mdn#1179)
  Issue#1005 web api examples editor (mdn#1142) (mdn#1174)
  chore(deps): update dependency husky to v1.1.1 (mdn#1173)
  chore(deps): update dependency puppeteer to v1.9.0 (mdn#1172)
  Adding an example for the String.toString() method (mdn#1076)
  Adding method for String.valueOf() method (mdn#1078)
  Added an example for String.length (mdn#1080)
  Clarifying Promise.resolve() Example (mdn#1125)
  Remove background from datalist example (mdn#1099)
  Remove background from option example (mdn#1102)
  Removed background image from optgroup (mdn#1101)
  Update <img> to use CC0 image (mdn#1087)
  use `+=` instead of `a = a + x` (mdn#1171)
  chore(deps): update dependency husky to v1.1.0 (mdn#1168)
  chore(deps): update dependency eslint to v5.6.1 (mdn#1167)
  chore(deps): update dependency stylelint to v9.6.0 (mdn#1165)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant