Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added example for RegExp.prototype.hasIndices #1782

Merged
merged 3 commits into from
Apr 5, 2021

Conversation

SebastianZ
Copy link
Contributor

This adds an interactive example for the newly introduced RegExp.prototype.hasIndices property.

This is in preparation of adding the related content.

Sebastian

@welcome
Copy link

welcome bot commented Mar 18, 2021

💖 Thanks for opening this pull request! 💖
Here is a list of things that will help get it across the finish line:

  • If this is a new or updated CSS interactive example, please ensure that you followed the CSS styleguide - If this is a new or updated JavaScript interactive example, please ensure that you followed the JavaScript styleguide - If your changes affects any of the steps in our contribution docs, please also make the relevant changes there.

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SebastianZ ! This looks fine. The DotAll example works fine, and the HasIndices examples works fine in newest Firefox 88 build and newest Chrome Canary.

The only problem we've got here is that the ESLint CI build is failing, I'm guessing because the version of ESLint we are using doesn't know about hasIndices yet. @schalkneethling can this be updated easily?

@escattone
Copy link
Contributor

I updated eslint to the latest version 7.23.0, but it still doesn't recognize the d flag as it should. I'm going to merge this for now, and we can keep looking into resolving the eslint issue.

@escattone escattone merged commit eb6bfed into mdn:master Apr 5, 2021
@welcome
Copy link

welcome bot commented Apr 5, 2021

Congrats on merging your first pull request! 🎉🎉🎉

@SebastianZ
Copy link
Contributor Author

Muchas gracias, Ryan, for merging my PR! 😃

I assume, the d flag is just too new and therefore not implemented in Node.js yet.

Sebastian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants