change no-invalid-regexp to warn for hasindices #1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about upgrading to |
I tried that first, but it didn't help. |
|
@peterbe In fact, I'll add that upgrade to this PR, just to show that approach doesn't resolve the issue (the warning is still issued). |
|
So even the latest version of eslint doesn't like this |
schalkneethling
approved these changes
Apr 15, 2021
escattone
deleted the
temp-disable-no-invalid-regexp-for-hasindices-example
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the
no-invalid-regexprule to a warning (rather than a error), but only for**/regexp/regexp-prototype-hasindices.js. We can remove this change onceeslintrecognizes the"d"flag to theRegExpconstructor.This will get the builds passing again after they were broken by #1782.