Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump stylelint-prettier from 2.0.0 to 3.0.0 #2450

Merged
merged 1 commit into from Feb 24, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 23, 2023

Bumps stylelint-prettier from 2.0.0 to 3.0.0.

Changelog

Sourced from stylelint-prettier's changelog.

3.0.0 (2023-02-22)

Remove stylelint-config-prettier from the recommended config. Stylelint v15 deprecated the rules that stylelint-config-prettier disabled, thus if you do not use those deprecated rules then you do not need stylelint-config-prettier. If you are still using these deprecated rules then you should install and configure stylelint-config-prettier separatly.

Increase the mimimum required node version. No code changes have been required and v2.0.0 works with stylelint v15, however continuing to test with the unsupported node 12 is a burden that is not worth carrying.

  • Minimum node requirement is now "^14.17.0 || >=16.0.0" (drop support for v12.x)
  • If you extended from the stylelint-prettier/recommended in v2 then you must add an explict extend from stylelint-config-prettier to retain the same behaviour.
Commits
  • cb2ad8d v3.0.0
  • 4149a0b v3 - Drop support for node 12, simplify recommended config in light of stylel...
  • 0200b6d Merge pull request #256 from nschonni/patch-1
  • 515b438 chore: remove double word "the"
  • 26b8422 Use jest-preset-stylelint
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [stylelint-prettier](https://github.com/prettier/stylelint-prettier) from 2.0.0 to 3.0.0.
- [Release notes](https://github.com/prettier/stylelint-prettier/releases)
- [Changelog](https://github.com/prettier/stylelint-prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/stylelint-prettier@v2.0.0...v3.0.0)

---
updated-dependencies:
- dependency-name: stylelint-prettier
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Feb 23, 2023
@caugner
Copy link
Contributor

caugner commented Feb 24, 2023

  • If you extended from the stylelint-prettier/recommended in v2 then you must add an explict extend from stylelint-config-prettier to retain the same behaviour.

This sounds like we need to update the .stylelintrc.

"extends": ["stylelint-prettier/recommended"],

edit: So what this means is that if we want to continue to use the stylistic rules that are being deprecated with stylelint v15, then we need to add stylelint-config-prettier here. BUT since we already use prettier to format, we don't need those deprecated rules, so we don't need to take any action.

@caugner
Copy link
Contributor

caugner commented Feb 24, 2023

@dependabot squash and merge

@dependabot dependabot bot merged commit 7845c66 into main Feb 24, 2023
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/stylelint-prettier-3.0.0 branch February 24, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant