Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding thead, tbody, and tfoot examples #848

Merged
merged 3 commits into from May 1, 2018
Merged

adding thead, tbody, and tfoot examples #848

merged 3 commits into from May 1, 2018

Conversation

chrisdavidmills
Copy link
Contributor

No description provided.

@wbamberg
Copy link
Contributor

These examples are great, but I have a couple of concerns with them.

  1. they overflow horizontally even at quite generous widths. This is what they would look like embedded on an MDN page, full-screen on my laptop (1440 px):

screen shot 2018-04-30 at 3 28 27 pm

  1. The HTML is very long. Ideally I want these examples to work for someone who doesn't want to interact with them - meaning that they should be able to see the HTML for the element without having to scroll the window. HTML is pretty wordy, and we will probably need to support a "taller" variant of the editor (see HTML editor size adjustments #693) - but even so I think we should try hard to keep the example to under 30 lines. These are 51 lines, which I think is too much. Apart from the scrolling thing, I think a long example makes it harder for someone to see and digest the element that's the subject of the demo. The mission for these examples is to be short, simple examples that give someone a quick understanding of the basics of the element.

@schalkneethling schalkneethling added p1 We will address this soon and will provide capacity from our team for it in the next few releases. in sprint labels May 1, 2018
@schalkneethling schalkneethling added this to the Quarter 2 ~ Sprint 2 milestone May 1, 2018
@chrisdavidmills
Copy link
Contributor Author

Points taken on board. I've cut down the amount of HTML in the example to under 30 lines.

wbamberg
wbamberg approved these changes May 1, 2018
View reviewed changes
Copy link
Contributor

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @chrisdavidmills . Looks good to me!

@wbamberg wbamberg merged commit dec42df into mdn:master May 1, 2018
wbamberg pushed a commit to wbamberg/interactive-examples that referenced this pull request May 1, 2018
Merge remote-tracking branch 'upstream/master'
e55e291 
* upstream/master:
  adding thead, tbody, and tfoot examples (mdn#848)
  Add input type=email example (mdn#840)
  Add picture example. (mdn#842)
  Add input-file example (mdn#852)
  Update dependency fs-extra to v6 (mdn#861)
  Add <input type="datetime-local"> example (mdn#838)
  Update dependency fs-extra to v5 (mdn#859)
  Update dependency browserify to v16 (mdn#858)
  Update dependency stylelint to v9.2.0 (mdn#857)
  Reinstate caption in meta.json (mdn#843)
  Update dependency jest-puppeteer to v2.4.0 (mdn#855)
  Update dependency puppeteer to v1.3.0 (mdn#856)
  Update dependency http-server to v0.11.1 (mdn#854)
  Update dependency bundlesize to v0.17.0 (mdn#853)
  Pin dependencies (mdn#851)
  Add <hgroup> example (mdn#846)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbamberg wbamberg wbamberg approved these changes

Assignees

@wbamberg wbamberg

Labels
p1 We will address this soon and will provide capacity from our team for it in the next few releases.
Projects
None yet
Milestone
Quarter 2 ~ Sprint 2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chrisdavidmills @wbamberg @schalkneethling