New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add object-keys.html #937

Merged
merged 2 commits into from May 28, 2018

Conversation

@elharony
Contributor

elharony commented May 18, 2018

This is the edited version of a previous Pull Request #725

It contains:

  • object-keys.html page
  • objectkeys object in meta.json

I've tried to update the previous Pull Request, but I couldn't. That's why I created a new one.

elharony added some commits Apr 17, 2018

Add object-keys.html
The code is the same as 'object-values.html' the only difference is that here we are printing out the `keys` not the `values`.

@elharony elharony changed the title from Add 'objectKeys' to 'meta.json' to Add object-keys.html May 18, 2018

@schalkneethling schalkneethling self-requested a review May 19, 2018

@schalkneethling schalkneethling self-assigned this May 19, 2018

@schalkneethling schalkneethling added this to To do in Examples Needed via automation May 19, 2018

@schalkneethling schalkneethling added this to the Q2 ~ Sprint 3 milestone May 19, 2018

@elharony

This comment has been minimized.

Contributor

elharony commented May 24, 2018

Hi @schalkneethling ,

Do I need to add something else to this Pull Request to be Merged? 🤔

@schalkneethling schalkneethling merged commit 7c1e5f3 into mdn:master May 28, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json No new issues
Details

Examples Needed automation moved this from To do to Done May 28, 2018

@welcome

This comment has been minimized.

welcome bot commented May 28, 2018

Congrats on merging your first pull request! 🎉🎉🎉

@wbamberg

This comment has been minimized.

Member

wbamberg commented May 28, 2018

I just updated the MDN page to include this example: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/keys

Thanks @elharony !

@elharony

This comment has been minimized.

Contributor

elharony commented May 30, 2018

Thank you @schalkneethling and @wbamberg !! 💯

wbamberg added a commit to wbamberg/interactive-examples that referenced this pull request Jun 8, 2018

Merge remote-tracking branch 'upstream/master'
* upstream/master:
  adding oblique plus angle option to font-style example (mdn#963)
  fix(tabbed-editor): Apply output class to output container (mdn#961)
  Add rt example. (mdn#957)
  chore(deps): update dependency prettier to v1.13.4 (mdn#953)
  chore(deps): update dependency all-contributors-cli to v4.11.2 (mdn#954)
  chore(deps): update dependency jest to v23.1.0 (mdn#955)
  Fix console util to support negative zero (mdn#960)
  Add rp example. (mdn#945)
  Bug 1462897 - Directly use Math.round in the demo code. (mdn#956)
  chore(docs): update README with maintainers and good first issues (mdn#934)
  Implemented example for <figcaption> tag (mdn#941)
  Font variation settings (mdn#948)
  Fix font optical sizing (mdn#947)
  chore(deps): update dependency jest to v23 (mdn#944)
  chore(deps): update dependency prettier to v1.13.0 (mdn#950)
  chore(community): add @elharony as contributor (mdn#951)
  Add object-keys.html (mdn#937)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment