Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add object-keys.html #937

Merged
merged 2 commits into from May 28, 2018
Merged

Add object-keys.html #937

merged 2 commits into from May 28, 2018

Conversation

elharony
Copy link
Contributor

@elharony elharony commented May 18, 2018

This is the edited version of a previous Pull Request #725

It contains:

  • object-keys.html page
  • objectkeys object in meta.json

I've tried to update the previous Pull Request, but I couldn't. That's why I created a new one.

elharony added 2 commits April 17, 2018 04:45
The code is the same as 'object-values.html' the only difference is that here we are printing out the `keys` not the `values`.
@elharony elharony changed the title Add 'objectKeys' to 'meta.json' Add object-keys.html May 18, 2018
@schalkneethling schalkneethling self-requested a review May 19, 2018 11:03
@schalkneethling schalkneethling self-assigned this May 19, 2018
@schalkneethling schalkneethling added this to the Q2 ~ Sprint 3 milestone May 19, 2018
@elharony
Copy link
Contributor Author

Hi @schalkneethling ,

Do I need to add something else to this Pull Request to be Merged? 🤔

Copy link
Contributor

@schalkneethling schalkneethling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ Thanks @elharony

@schalkneethling schalkneethling merged commit 7c1e5f3 into mdn:master May 28, 2018
@welcome
Copy link

welcome bot commented May 28, 2018

Congrats on merging your first pull request! 🎉🎉🎉

@wbamberg
Copy link
Contributor

I just updated the MDN page to include this example: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/keys

Thanks @elharony !

@elharony
Copy link
Contributor Author

Thank you @schalkneethling and @wbamberg !! 💯

wbamberg pushed a commit to wbamberg/interactive-examples that referenced this pull request Jun 8, 2018
* upstream/master:
  adding oblique plus angle option to font-style example (mdn#963)
  fix(tabbed-editor): Apply output class to output container (mdn#961)
  Add rt example. (mdn#957)
  chore(deps): update dependency prettier to v1.13.4 (mdn#953)
  chore(deps): update dependency all-contributors-cli to v4.11.2 (mdn#954)
  chore(deps): update dependency jest to v23.1.0 (mdn#955)
  Fix console util to support negative zero (mdn#960)
  Add rp example. (mdn#945)
  Bug 1462897 - Directly use Math.round in the demo code. (mdn#956)
  chore(docs): update README with maintainers and good first issues (mdn#934)
  Implemented example for <figcaption> tag (mdn#941)
  Font variation settings (mdn#948)
  Fix font optical sizing (mdn#947)
  chore(deps): update dependency jest to v23 (mdn#944)
  chore(deps): update dependency prettier to v1.13.0 (mdn#950)
  chore(community): add @elharony as contributor (mdn#951)
  Add object-keys.html (mdn#937)
@estelle estelle mentioned this pull request Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants