This repository has been archived by the owner on Apr 5, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
Panel icon colours responding to DevTools theme options #1
Comments
Looking into the sources I've found that in the other tools dark/light icon switch is accomplished applying an svg filter to the icon image: This filter is applied only on tool registered with a new "invertIconForLightTheme" option set to true:
@Gozala, how about exposing the new attributes on the DevTools SDK Panel class? |
I've filed a bug for this: https://bugzilla.mozilla.org/show_bug.cgi?id=1095222. Even if we don't do it using color inversion, I think it's important for add-on authors to get their icons looking good with both themes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
@wbamberg First off, just wanted to say thanks for making this - it's been a huge help in getting started on an addon I'm working on. One thing I've found though is that using the native DevTools theme switcher to alternate back and forth between the light and dark options can obscure a single-colour icon. Example:
Stock light theme:
![image](https://cloud.githubusercontent.com/assets/1245284/4919113/6a20a27c-64f7-11e4-8b3a-b60d352edcc5.png)
![image](https://cloud.githubusercontent.com/assets/1245284/4919118/748f6b26-64f7-11e4-9424-438368e4fd68.png)
Stock dark theme:
Do you know if there's a recommended way to switch icons depending on theme, at least for the two that come with FF?
Thanks!
The text was updated successfully, but these errors were encountered: