-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch on/off button not implemented #25
Comments
This is true. @Rumyra , was this intentional? I don't think it is a big deal in any case. |
Yes this was intentional I was pre-empting phase two of the boombox. I can happily remove the button and re-implement for version 2 if it's a problem/confusing? |
Yeah, I think commenting out for now would be good |
Hi, @Rumyra If the issue is open can I temporarily delete it or comment button to contribute to it? |
Hey @rohini-ranjanR yes that would be great - if you want to delete or comment out ping me and I'll review the pr 👍 |
Thanks, @Rumyra here's my PR. |
webaudio-examples/audio-basics/index.html
Line 33 in e7f0c80
The text was updated successfully, but these errors were encountered: