Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using npx/global installs vs. relying on repo's dependencies #80

Open
nschonni opened this issue Sep 28, 2022 · 0 comments
Open

Using npx/global installs vs. relying on repo's dependencies #80

nschonni opened this issue Sep 28, 2022 · 0 comments
Labels
effort: medium This task is medium effort. enhancement Improves an existing feature. on hold Waiting on something else before this can be moved forward. p3 We don't have visibility when this will be addressed.

Comments

@nschonni
Copy link
Contributor

EX: the shared workflow uses npx

workflows/.github/workflows/markdown-lint.yml

Line 38 in ccb17a4

npx markdownlint-cli '*.md' -i LICENSE.md -i CODE_OF_CONDUCT.md

Where the downstream repo uses it's own yarn.lock version
https://github.com/mdn/content/blob/46104c1adfef5d2d696711324aa7007634bba4a7/.github/workflows/markdown-lint.yml#L27-L34

Should the shared repos assume downstream fixed dependency and script names, or hoist it's own lock file that needs to be synced. The downstream repos likely can't drop those dependencies, as they're used for things like Husky hooks
@caugner caugner added needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. enhancement Improves an existing feature. effort: medium This task is medium effort. p3 We don't have visibility when this will be addressed. and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Oct 10, 2023
@caugner caugner added the on hold Waiting on something else before this can be moved forward. label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: medium This task is medium effort. enhancement Improves an existing feature. on hold Waiting on something else before this can be moved forward. p3 We don't have visibility when this will be addressed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@caugner @nschonni