-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ai-help): show canned answer without sources for off-topic questions #10575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
plus
work around features related to MDN Plus
plus:ai-help
labels
Feb 22, 2024
caugner
changed the title
feat(ai-help): show error for off-topic questions
feat(ai-help): show canned answer without sources for off-topic questions
Feb 23, 2024
github-actions
bot
added
the
merge conflicts 🚧
Please rebase onto or merge the latest main.
label
Feb 27, 2024
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
removed
the
merge conflicts 🚧
Please rebase onto or merge the latest main.
label
Feb 28, 2024
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
added
the
merge conflicts 🚧
Please rebase onto or merge the latest main.
label
Feb 29, 2024
github-actions
bot
removed
the
merge conflicts 🚧
Please rebase onto or merge the latest main.
label
Mar 1, 2024
caugner
commented
Mar 1, 2024
caugner
commented
Mar 1, 2024
argl
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(MP-710)
Problem
We show consulted MDN content even for off-topic questions.
Solution
Show a canned answer without sources if we detect an off-topic question.
Screenshots
Before
After
Video:
Screen.Recording.2024-02-23.at.14.16.57.mov
How did you test this change?
Asked
What is the best type of coffee to drink while coding?
locally with mdn/rumba#427.