fix(cloud-function): use URL.pathname to resolve index.html only #11271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When migrating from `url.parse()` to `new URL()`, we accidentally started adding `req.protocol` and `req.headers.host` to the resolved URL.
argl
approved these changes
Jun 7, 2024
|
Verified fix on stage: https://developer.allizom.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11270, a regression caused by #9655.
Problem
When migrating from
url.parse()tonew URL(), we accidentally started addingreq.protocolandreq.headers.hostto the resolved URL.Solution
Use the resolved
pathnamewithout protocol/host/search/hash.Screenshots
Before
After
How did you test this change?
Ran
npm startin/cloud-function, andcurl -I http://localhost:5100/en-US/docs/Mozilla/Add-ons/WebExtensions/Browser_compatibility_for_manifest.jsonseparately.