chore(types): narrow string to Locale where possible #11323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C17AN
changed the title
C17AN
changed the title
C17AN
force-pushed
the
chore/Locale-typing
branch
from
c89421e
to
dc1f184
Compare
|
While correcting the Lint error, I realized that more changes were needed than I thought. I think it would be meaningful to change the string type to the Locale type, but there is a concern that this change could lead to a breaking change. I would appreciate it if you could feel free to leave your comments on what you think. |
C17AN
force-pushed
the
chore/Locale-typing
branch
from
dc1f184
to
3f422d6
Compare
C17AN
force-pushed
the
chore/Locale-typing
branch
from
3f422d6
to
c11cc86
Compare
C17AN
force-pushed
the
chore/Locale-typing
branch
2 times, most recently
from
176a036
to
72829bb
Compare
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
added
the
merge conflicts 🚧
caugner
approved these changes
Jun 24, 2024
github-actions
bot
removed
the
merge conflicts 🚧
caugner
changed the title
|
Thank you for your review, @caugner! |
Thank you, we're all good, and I just merged! 🎉 |
3 tasks
ferdnyc
pushed a commit
to ferdnyc/yari
that referenced
this pull request
Jul 13, 2024
Co-authored-by: Claas Augner <caugner@mozilla.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
As the locale key value is widely used in the project, I thought it would be better to manage it more thoroughly.
Solution
Narrow
localeproperty's type fromstringtoLocale.Before
After