fix(pong): remove div/p #11393
Merged
fix(pong): remove div/p #11393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove an unnecessary p and resolve an invalid DOM nesting issue.
caugner
approved these changes
Jul 1, 2024
|
Yes, verified that. But broke on the Obeservatory HP which is not in this branch so I made is more robust: a268b37 |
ferdnyc
pushed a commit
to ferdnyc/yari
that referenced
this pull request
Jul 13, 2024
* fix(pong): remove div/p Remove an unnecessary p and resolve an invalid DOM nesting issue. * fix height if not inherited
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove an unnecessary p and resolve an
invalid DOM nesting issue.
Problem
<p><div><div></p>is not allowed.Solution
Remove the
<p>.Screenshots
Nothing changed.
How did you test this change?
Locally