Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(baseline): hide when feature status differs from BCD key status #11547

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

LeoMcA
Copy link
Member

@LeoMcA LeoMcA commented Jul 26, 2024

Summary

https://mozilla-hub.atlassian.net/browse/MP-874

Also see: #11546

Problem

  • We maintain an manual blocklist of BCD keys to not display Baseline banners for, since they're potentially confusing
  • Some BCD keys are part of a feature which has a higher status (i.e. Baseline low or high if the BCD key is not Baseline, or Baseline high if the BCD key is Baseline low), and so we display an incorrect banner on those pages:

Solution

  • Compute the per-key Baseline status for each page with compute-baseline, and if that status disagrees with the feature status, hide the banner

How did you test this change?

@LeoMcA LeoMcA requested review from mdn-bot and a team as code owners July 26, 2024 15:53
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Jul 26, 2024
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two nits and one comment.

PS: Didn't actually test.

build/web-features.ts Outdated Show resolved Hide resolved
build/web-features.ts Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@LeoMcA LeoMcA merged commit b493ff2 into main Jul 30, 2024
16 checks passed
@LeoMcA LeoMcA deleted the compute-baseline-blocklist branch July 30, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants