Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contributor-spotlight): some old pages not building #11679

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

LeoMcA
Copy link
Member

@LeoMcA LeoMcA commented Aug 23, 2024

Summary

https://mozilla-hub.atlassian.net/browse/MP-1448

Problem

Some contributor spotlight pages don't build because we bail as soon as we hit the featured contributor.

Solution

Don't do that, build all contributor spotlight pages.


@LeoMcA LeoMcA requested a review from a team as a code owner August 23, 2024 14:02
Copy link
Contributor

@argl argl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fiji-flo fiji-flo self-requested a review September 3, 2024 09:29
Copy link
Contributor

@fiji-flo fiji-flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fiji-flo fiji-flo merged commit 5adb9eb into main Sep 5, 2024
12 checks passed
@fiji-flo fiji-flo deleted the fix-building-old-featured-contributors branch September 5, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants