Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For iOS Safari, the color of status bar remains white even if dark mode is on. Because of <meta name="theme-color" content="#ffffff" /> #7884

Closed
3 tasks done
3-2 opened this issue Dec 29, 2022 · 5 comments · Fixed by #9325
Labels
contrast issues related to low contrast, especially in dark mode dark-mode Issues related to dark/light mode effort: medium This task is a medium effort. frontend general frontend issues has PR Issues that already have a PR needs decision from engineering p3 We don't have visibility when this will be addressed.

Comments

@3-2
Copy link

3-2 commented Dec 29, 2022

Summary

There is such a line in yari/client/public/index.html:
<meta name="theme-color" content="#ffffff" />
This code restricts the color of status bar to white in Safari for iOS.

Therefore, status bar remains white even if dark mode is on in iOS, which is glaring at night.

Note: this issue doesn't only happen on developer.mozilla.org, but also on support.mozilla.org.

URL

https://developer.mozilla.org

Reproduction steps

  1. Open Safari for iOS.
  2. Visit https://developer.mozilla.org.
  3. Switch dark mode again and again, you can see the color of status bar remains white.

Expected behavior

The color of status bar follows dark mode.

Actual behavior

The color of status bar remains white

Device

Smartphone

Browser

Safari

Browser version

Stable

Operating system

iOS

Screenshot

No response

Anything else?

No response

Validations

@bsmth bsmth added needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. and removed needs-triage labels Mar 3, 2023
@mirunacurtean mirunacurtean added frontend general frontend issues needs decision from engineering dark-mode Issues related to dark/light mode contrast issues related to low contrast, especially in dark mode and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Mar 30, 2023
@github-actions github-actions bot added the idle label Jun 20, 2023
@3-2 3-2 closed this as completed Sep 24, 2023
@caugner caugner reopened this Oct 27, 2023
@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Oct 27, 2023
@3-2
Copy link
Author

3-2 commented Oct 27, 2023

@caugner
Hello!
This issue had been solved. Why did you reopen it?

@caugner
Copy link
Contributor

caugner commented Oct 27, 2023

@3-2 It looks like the issue is not yet resolved, as the PR is not merged yet.

@caugner caugner added has PR Issues that already have a PR p3 We don't have visibility when this will be addressed. labels Oct 27, 2023
@3-2
Copy link
Author

3-2 commented Oct 27, 2023

@caugner
I'm not familiar with how GitHub operates. I just see the fact that the colour of status bar now meets user expectation under any situation. It’s black under dark mode.
Can you explain why this issue should keep opened? This will help me be familiar with how GitHub operates. Thank you!

@github-actions github-actions bot removed the idle label Oct 27, 2023
@3-2
Copy link
Author

3-2 commented Oct 28, 2023

Alright, I'm wrong...It really isn't resolved. It's because of the dark mode extension installed on my Safari that made me feel like the issue had been resolved.
Sorry...@caugner

@caugner caugner added effort: medium This task is a medium effort. and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Oct 30, 2023
@caugner
Copy link
Contributor

caugner commented Nov 6, 2023

@3-2 For your information, this should be resolved in the meantime. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contrast issues related to low contrast, especially in dark mode dark-mode Issues related to dark/light mode effort: medium This task is a medium effort. frontend general frontend issues has PR Issues that already have a PR needs decision from engineering p3 We don't have visibility when this will be addressed.
Projects
Development

Successfully merging a pull request may close this issue.

5 participants