fix(ui): gap at top of page in tablet mode #8885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
due to a non-integer pixel height, also fixes cropped icons in article actions menu for the same reason
caugner
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Header jumps around when opening the menu in tablet mode, exposing a 1px gap at the top of the page.
Icons in the article actions menu also appear cropped, due to half-pixel offset.
Solution
Make header and article actions band full-pixel heights, rather than half pixel.
Screenshots
Before
Observe the whole page seem to shift down 1px, including the header (look at the logo), and a gap at the top you can see some text peeking through, when the menu opens. Also observe the icons in article actions be cropped at the bottom when the menu opens:
Screencast.from.2023-05-18.11-11-11.webm
After
Screencast.from.2023-05-18.11-13-37.webm