Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blog links appear as links to unwritten pages #9345

Closed
bozoputer opened this issue Jul 18, 2023 · 3 comments · Fixed by #9839
Closed

Blog links appear as links to unwritten pages #9345

bozoputer opened this issue Jul 18, 2023 · 3 comments · Fixed by #9839
Assignees
@caugner
Labels
🐛 bug Something isn't working, or isn't working as expected effort: medium This task is a medium effort. flaw-system issues and feature requests related to the flaws system p2 We want to address this but may have other higher priority items.

Comments

@bozoputer
Copy link

bozoputer commented Jul 18, 2023 •
edited
Loading

MDN URL

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/landmark_role

What specific section or headline is this issue about?

See Also

What information was incorrect, unhelpful, or incomplete?

The link Using HTML landmark roles to improve accessibility on MDN blog (2023) is styled in red with a squiggly underline and a tooltip that says it is a link to an unwritten page, however, that is no longer the case, as the page has been written.

What did you expect to see?

The link styled in a similar fashion as those preceding it.

Do you have any supporting links, references, or citations?

N/A

Do you have anything more you want to share?

No response

MDN metadata

Page report details
@bozoputer bozoputer added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jul 18, 2023
@Josh-Cena
Copy link
Member

mdn/content#27298 made these links absolute but mdn/content#28009 changed them back to relative. This should be a Yari issue because fix-flaws shouldn't update them.

@Josh-Cena Josh-Cena removed the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jul 19, 2023
@sideshowbarker sideshowbarker transferred this issue from mdn/content Jul 20, 2023
@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jul 20, 2023
@yin1999
Copy link
Member

yin1999 commented Jul 20, 2023

This flaws system's issue should be fixed by #9080. I've tested this locally :)

image

@caugner
Copy link
Contributor

caugner commented Jul 21, 2023

Looks like #9080 didn't fix it on production. 😕

@caugner caugner added 🐛 bug Something isn't working, or isn't working as expected flaw-system issues and feature requests related to the flaws system labels Jul 21, 2023
@caugner caugner added p2 We want to address this but may have other higher priority items. and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Oct 2, 2023
@caugner caugner changed the title Link to written page Blog links appear as links to unwritten pages Oct 5, 2023
@caugner caugner added the effort: medium This task is a medium effort. label Oct 12, 2023
@caugner caugner self-assigned this Oct 17, 2023
@caugner caugner mentioned this issue Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caugner caugner

Labels
🐛 bug Something isn't working, or isn't working as expected effort: medium This task is a medium effort. flaw-system issues and feature requests related to the flaws system p2 We want to address this but may have other higher priority items.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(flaws): exclude /en-US/blog/* from broken-link flaw mdn/yari
4 participants
@caugner @bozoputer @yin1999 @Josh-Cena