feat(cli): Fix recursive document deletion #9486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@queengooborg I think there are places where we have the strong assumption that there's always a "parent" (if not top level). It's been a while but I think the idea was to make recursive deletion explicit (like in many unix programs). The issue was probably introduced in #4775 and I'd have us rather fix that. |
queengooborg
changed the title
|
That's a fair point -- logic re-reversed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the recursive document deletion.
While we have always had a
--recursiveargument, it has basically been ineffective, because the recursive deletion had not been implemented behind the argument. Because of this, recursive deletion would always occur regardless of the argument's value.