Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(docs): distinguish nested definition lists #9836

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Oct 17, 2023

Summary

(MP-616)

Problem

Nested definition lists are hard to distinguish from the parent definition list's item.

Solution

Adds indentation and a border on the left.


Screenshots

Before

image

After

image


How did you test this change?

Ran yarn && yarn dev and looked at http://localhost:3000/en-US/docs/Web/HTML/Element/img#fetchpriority locally.

Adds indentation and a border on the left.
@caugner caugner requested a review from a team October 17, 2023 16:20
Copy link
Member

@LeoMcA LeoMcA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice! 🚀

@caugner caugner merged commit f8b48f2 into main Oct 17, 2023
14 checks passed
@caugner caugner deleted the distinguish-nested-dls branch October 17, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants