Another stab at #48: Proper watch and star buttons #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue seems to be caused by an overload of the GitHub API.
|
/cc @therealklanni |
This was referenced May 18, 2014
|
Looks good. I think regarding users having to update, I don't think it will be an unwelcome change, considering the verbiage is now more accurate. Thanks! |
|
Afterthought: may want to add something in the README.md to explain the "breaking changes"? |
…yles and gradients, and a smaller image
This was referenced May 18, 2014
Closed
Closed
|
Why not add a 'VERSION=2' to the include url? |
|
🚢 🇮🇹 |
|
Revamped this some more:
|
|
👍 |
mdo
added a commit
that referenced
this pull request
Jan 20, 2015
Another stab at #48: Proper watch and star buttons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes #48 and fixes a few things:
Should be good to go, I think. I'll mark this as v2 once merged. My only concern is folks who have used
watchto previously mean Star. They'll have to change all their embeds, and that's not so good.Thoughts?