Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul to remove outdated styles, refresh for UI changes #49

Merged
merged 6 commits into from
Feb 19, 2019
Merged

Overhaul to remove outdated styles, refresh for UI changes #49

merged 6 commits into from
Feb 19, 2019

Conversation

mdo
Copy link
Owner

@mdo mdo commented Jul 19, 2018 •
edited
Loading

  • Better code comments and organization of styles.
  • Account for new .container-lg used on more pages by sharing the general .container styles. This fixes profile pages, Marketplace content, and site header not going full-width.
  • Update profile pages with improved profile photo placement and fixed pinned repos.
  • Removed all settings overrides; they're now entirely unnecessary in my testing.
  • Remove old GitHub "repo next" styles.
  • Adds max-width to network graph to close Fixed Insights Network Graph #44 and fix any way to enlarge the network graph #50

This was referenced Jul 19, 2018
Closed
Closed
Closed
@cfoellmann
Copy link
Contributor

2018-07-19 2

a little bit of overflow

@cfoellmann cfoellmann mentioned this pull request Jul 19, 2018
Closed
@mdo
Copy link
Owner Author

mdo commented Jul 19, 2018

Hmm, very strange, I don't see this in latest Safari or Chrome.

@cfoellmann cfoellmann mentioned this pull request Jul 20, 2018
Closed
@cfoellmann
Copy link
Contributor

I am on win10 + chrome.
I will have another look and maybe someone else can confirm

@snowe2010
Copy link

Discover repositories tab on homepage causes weird issue with the right bar.

screenshot 2018-07-20 13 09 29

@snowe2010
Copy link

Profile page looks a bit weird.

screenshot 2018-07-20 13 11 23

@snowe2010
Copy link

macOS 10.12.6, Firefox 61.0.1
I verified my 2 other userstyles didn't cause this.

This was referenced Jul 23, 2018
Closed
Closed
@cfoellmann
Copy link
Contributor

can we just get this into master? github.com is evolving and the current master doesnt do anything good for anyone anymore

@mdo mdo merged commit 493585d into master Feb 19, 2019
@mdo mdo deleted the v2 branch February 19, 2019 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljmf00 ljmf00 ljmf00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

any way to enlarge the network graph
5 participants
@mdo @cfoellmann @snowe2010 @ljmf00 @marcoesposito1988