Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear out compiler warnings and remarks #53

Open
anilyil opened this issue Jun 5, 2020 · 2 comments
Open

Clear out compiler warnings and remarks #53

anilyil opened this issue Jun 5, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request installation This is related to installation of the package

Comments

@anilyil
Copy link
Contributor

anilyil commented Jun 5, 2020

Type of issue

  • Code formatting

Description

We have a bunch of warnings and remarks generated during compilation of ADflow. PR #52 addresses most of these issues; however, we still have some warnings remaining:

  1. Complex builds still complain about missing modules. @nwu63 and I will work on this with the PR Warnings fix #52.
  2. The forces array is defined as an output variable with the getForces_b routine, but is not used. I did not modify this now, but we can edit the call signature and/or modify the intent. The warning looks like this:
../warping/getForces.F90(124): warning #6843: A dummy argument with an explicit INTENT(OUT) declaration is not given an explicit value.   [FORCES]
  1. With intel compilers, we get a lot of remarks about output formats from fortran files. These remarks look like this:
remark #8291: Recommended relationship between field width 'W' and the number of fractional digits 'D' in this edit descriptor is 'W>=D+7'.

Here is the explanation of this from doctor fortran himself: https://software.intel.com/en-us/forums/intel-fortran-compiler/topic/635137
This can be easily fixed, but we need to check if all outputs look okay after the fix.
4. There are a bunch of warnings generated by the f2py wrapping. These contain:

warning #1224: #warning directive: "Using deprecated NumPy API, disable it by "          "#defining NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION"

and a bunch of

libadflowmodule.c(11948): warning #556: a value of type "void (*)(int *, int *, void (*)(char *, int *), int *)" cannot be assigned to an entity of type "f2py_init_func"
    f2py_communication_def[i_f2py++].func = sendrequests;
@anilyil anilyil added the enhancement New feature or request label Jun 5, 2020
@anilyil anilyil mentioned this issue Jun 6, 2020
1 task
@sseraj
Copy link
Collaborator

sseraj commented Jun 8, 2020

  1. Additional f2py warnings include:
    getarrdims:warning: assumed shape array, using 0 instead of ':'
    and
    warning: assignment from incompatible pointer type

@ewu63 ewu63 added the installation This is related to installation of the package label Feb 1, 2021
@ewu63
Copy link
Collaborator

ewu63 commented Mar 10, 2021

The NPY_NO_DEPRECATED_API stuff is due Cython/Numpy which should get fixed at some point, but in the mean time it's fine to leave the harmless messages in. See here for more details.

@mdolab mdolab deleted a comment from kristiantorres Feb 14, 2022
@ewu63 ewu63 removed their assignment Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request installation This is related to installation of the package
Projects
None yet
Development

No branches or pull requests

3 participants