Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix to support CGNS 4.4 #90

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Minor fix to support CGNS 4.4 #90

merged 2 commits into from
Sep 12, 2023

Conversation

eirikurj
Copy link
Contributor

@eirikurj eirikurj commented Aug 26, 2023

Purpose

The CGNS library removed legacy constants. This change is backwards compatible with the CGNS version we currently support.

Closes #91

Expected time until merged

No rush

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@eirikurj eirikurj requested a review from a team as a code owner August 26, 2023 11:45
@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Merging #90 (773cc9e) into main (c65ed8f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #90   +/-   ##
=======================================
  Coverage   73.31%   73.31%           
=======================================
  Files           6        6           
  Lines         757      757           
=======================================
  Hits          555      555           
  Misses        202      202           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eirikurj
Copy link
Contributor Author

The Tapenade tests should pass once #89 is merged

@sseraj sseraj merged commit 2c4769b into main Sep 12, 2023
17 checks passed
@sseraj sseraj deleted the fixCGNS branch September 12, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Symbol ‘null’ at (1) has no IMPLICIT type" when compiling
3 participants