Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update differentiated files to latest tapenade version #89

Merged
merged 7 commits into from
Sep 11, 2023
Merged

Conversation

eirikurj
Copy link
Contributor

@eirikurj eirikurj commented Aug 25, 2023

Purpose

This PR updates the AD'd files to the latest Tapenade version. The ADFirstAidKit files are also updated. Current pinned Tapenade version (Jul 2021) creates nonstandard type declarations, so postprocessing steps are added.

Expected time until merged

Few days

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@eirikurj eirikurj requested a review from a team as a code owner August 25, 2023 14:41
@eirikurj eirikurj requested review from sseraj and awccopp August 25, 2023 14:41
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #89 (77bb50b) into main (62e5fac) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #89   +/-   ##
=======================================
  Coverage   73.31%   73.31%           
=======================================
  Files           6        6           
  Lines         757      757           
=======================================
  Hits          555      555           
  Misses        202      202           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

marcomangano
marcomangano previously approved these changes Aug 26, 2023
@eirikurj eirikurj mentioned this pull request Aug 28, 2023
13 tasks
Copy link
Collaborator

@sseraj sseraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the Tapenade make process so that running make -f Makefile_tapenade by default runs ad_forward and ad_reverse? It would also be nice to clean up the temp_forward and temp_reverse directories.

src/adjoint/ADFirstAidKit/adDebug.c Outdated Show resolved Hide resolved
@eirikurj
Copy link
Contributor Author

eirikurj commented Sep 1, 2023

@sseraj updated the Makefile rules a bit as you suggested. I also made minor adjustments to autoedit scripts to check input and reduce code duplication.

Copy link
Collaborator

@sseraj sseraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up the build process!

@sseraj sseraj requested review from lamkina and removed request for awccopp September 8, 2023 14:28
@lamkina lamkina merged commit c65ed8f into main Sep 11, 2023
@sseraj sseraj deleted the updateTapenade branch September 11, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants