Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename functions #91

Merged
merged 7 commits into from
Jul 14, 2021
Merged

Rename functions #91

merged 7 commits into from
Jul 14, 2021

Conversation

hajdik
Copy link
Contributor

@hajdik hajdik commented Jul 13, 2021

Purpose

This PR renames functions as recommended in this issue. Wrappers were added so old function names redirect to new ones and raise a warning to the user.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Old instances of names should no longer be present (excluding wrappers) and use of old names should raise a warning.

Checklist

Put an x in the boxes that apply.

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@hajdik hajdik marked this pull request as ready for review July 13, 2021 15:27
@hajdik hajdik requested a review from a team as a code owner July 13, 2021 15:27
@ewu63 ewu63 linked an issue Jul 13, 2021 that may be closed by this pull request
ewu63
ewu63 previously approved these changes Jul 13, 2021
Copy link
Contributor

@marcomangano marcomangano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!! I double checked for any missing functions for safety. Just bumped the minor version, will make a new release after this PR is merged

@marcomangano marcomangano merged commit b3501d3 into mdolab:master Jul 14, 2021
@ewu63 ewu63 mentioned this pull request Jul 14, 2021
12 tasks
@hajdik hajdik deleted the rename_functions branch July 20, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename addGeoDV functions
3 participants