Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pygeo function calls #50

Merged
merged 2 commits into from
Jul 16, 2021
Merged

Update pygeo function calls #50

merged 2 commits into from
Jul 16, 2021

Conversation

hajdik
Copy link
Contributor

@hajdik hajdik commented Jul 13, 2021

Purpose

Function names in pygeo changed due to this issue in this PR, causing example scripts and tests in other repos to change as well.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Example scripts should run with no warnings on newest pygeo when changes are merged

Checklist

Put an x in the boxes that apply.

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@ewu63 ewu63 marked this pull request as ready for review July 16, 2021 13:52
@ewu63 ewu63 requested a review from a team as a code owner July 16, 2021 13:52
@ewu63 ewu63 requested review from eirikurj and sseraj July 16, 2021 13:52
@ewu63 ewu63 merged commit b16c333 into mdolab:master Jul 16, 2021
@hajdik hajdik deleted the rename_functions branch July 20, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants