Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add youtube channels to the youtube integration #10

Closed
mdolr opened this issue Oct 5, 2019 · 5 comments
Closed

Add youtube channels to the youtube integration #10

mdolr opened this issue Oct 5, 2019 · 5 comments
Labels
good first issue Good for newcomers hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest priority Should be trated in priority

Comments

@mdolr
Copy link
Owner

mdolr commented Oct 5, 2019

Currently the youtube integration only works for videos since #8 .
Add the preview of channels in js/templates/youtube.js

You should make it so that you find a way to consistantly identify channel links and return the type of a link being channel in the checkLinkType function

You should inject the HTML elements needed to preview a channel when the link is hovered in the bindToNode function (please do not use innerHTML and prefer DOM manipulation for firefox support)

@mdolr mdolr added good first issue Good for newcomers hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest labels Oct 5, 2019
@egfanboy
Copy link

egfanboy commented Oct 6, 2019

I investigated this for a little bit.

The embedded channel will only show some playlist for a channel.

Also you would need to make an API call with the chanelId to get the channel username to embed the channel

@mdolr
Copy link
Owner Author

mdolr commented Oct 6, 2019

I looked into that, maybe we could use the page's metadata as it provides the channel description, the channel icon and the channel's name.

@mdolr mdolr added the priority Should be trated in priority label Oct 13, 2019
@lavina98
Copy link

Hi
This API can be consumed for the channel name, image, description & subcribers.
https://developers.google.com/youtube/v3/docs/channels/list?apix_params=%7B%22part%22%3A%22statistics%22%2C%22id%22%3A%22UCGMcVCg3tHKmy9oaUCIw8xw%22%7D#usage
The request parameters include:
part - brandingSettings, statistics
id- (channel id)
You need authorization & API key

@mdolr
Copy link
Owner Author

mdolr commented Oct 14, 2019

Hello @lavina98 thanks for your suggestion, I think we've already discussed the use of the youtube API in #13 but it seem like a pretty bad solution as we would need to share the API Key, or have our own API, and we would have troubles scaling with the ratelimits.

@hisakiyo
Copy link
Contributor

hisakiyo commented Oct 4, 2020

#45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest priority Should be trated in priority
Projects
None yet
Development

No branches or pull requests

4 participants