Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github user integration #108

Open
mdolr opened this issue Oct 10, 2020 · 6 comments
Open

Github user integration #108

mdolr opened this issue Oct 10, 2020 · 6 comments
Labels
enhancement New feature or request Future improvements Should be treated / discussed for future versions good first issue Good for newcomers hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest help wanted Extra attention is needed

Comments

@mdolr
Copy link
Owner

mdolr commented Oct 10, 2020

Goes with #107 and it could display things like :

  • Username
  • Repository count ?
  • Languages ?
  • Workplace, organization ?
  • Website ?
  • Twitter profile etc...
@mdolr mdolr added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest Future improvements Should be treated / discussed for future versions labels Oct 10, 2020
@mdolr mdolr mentioned this issue Oct 11, 2020
Closed
@silenteyesoncode
Copy link

like to work on this
have done this before too

@mdolr
Copy link
Owner Author

mdolr commented Oct 12, 2020

Feel free to 👍

@silenteyesoncode
Copy link

i need to add client ID and secret
or I'll leave the comment, you can add it by creating git auth

@silenteyesoncode
Copy link

Nevertheless where you want to display the user profile?

@mdolr
Copy link
Owner Author

mdolr commented Oct 14, 2020

Why would we need to add API credentials ? I’m pretty sure `GET /users/{username}ˋ doesn’t require any OAuth authentication.

The profile should be disolayed as any other website, you could try to copy github’s preview or implement your own layout. I’d recommend reading CONTRIBUTING.MD if you feel confused

@joelazwar
Copy link
Contributor

Hey @mdolr I've been working on this feature and here are the results so far
survol github light
github dark

Anything you would like to add? Since I'm probably going to pull request this soon

@joelazwar joelazwar mentioned this issue Oct 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Future improvements Should be treated / discussed for future versions good first issue Good for newcomers hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mdolr @joelazwar @silenteyesoncode