Skip to content

Commit

Permalink
Disable support for shogun > 1
Browse files Browse the repository at this point in the history
it would be too much work to enable support for newer shogun versions...
  • Loading branch information
otizonaizit committed Mar 1, 2016
1 parent fca5f61 commit 569be36
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions mdp/configuration.py
Original file line number Diff line number Diff line change
Expand Up @@ -370,17 +370,17 @@ def set_configuration():
if os.getenv('MDP_DISABLE_SHOGUN'):
config.ExternalDepFailed('shogun', 'disabled')
else:
# From now on just support shogun >= 1.0
# Between 0.10 to 1.0 there are too many API changes...
# From now on just support shogun < 2.0
# Between 0.10 to 1.0 or beyond there are too many API changes...
try:
version = sgKernel.Version_get_version_release()
except AttributeError:
config.ExternalDepFailed('shogun',
'too old, upgrade to at least version 1.0')
'only shogun v1 is supported')
else:
if not version.startswith('v3.'):
if not version.startswith('v1.'):
config.ExternalDepFailed('shogun',
'too old, upgrade to at least version 1.0.')
'only shogun v1 is supported')
else:
config.ExternalDepFound('shogun', version)

Expand Down

0 comments on commit 569be36

Please sign in to comment.