Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data): Contracts #36

Closed
mds1 opened this issue Aug 10, 2023 · 3 comments · Fixed by #45
Closed

feat(data): Contracts #36

mds1 opened this issue Aug 10, 2023 · 3 comments · Fixed by #45

Comments

@mds1
Copy link
Owner

mds1 commented Aug 10, 2023

This issue is eligible for a bounty paid out in OP tokens. Read CONTRIBUTING.md to learn how to qualify.

  • Are contracts like Multicall3, 0x4e59b44847b379578588920cA78FbF26c0B4956C, 0age's create2 factory, xdeployer, Gnosis Safe contracts, etc. deployed? If so, at what addresses, links to deploy instructions, and references.
  • Canonical addresses for popular protocols: Should we just show the top X protocols on DeFiLlama by TVL? TVL doesn't make sense for all protocols though, e.g. Umbra, so maybe this just becomes an "anything goes" list where everything is hidden by default and you can search, this way people can PR in their own protocols. We can either leave this out for the scope of the issue, or include e.g. Uniswap V3 just so there's a template for people to add more protocols in the future
  • Canonical addresses for popular tokens: Same question as previous bullet. We should include WETH (not always called WETH depending on the chain, e.g. Polygon's native token is MATIC so the wrapped version is WMATIC), DAI, USDC, and USDT to start
@engn33r
Copy link

engn33r commented Sep 13, 2023

To expand on the Gnosis Safe thought, there can be questions about whether certain versions of Gnosis Safe contracts are compatible with a specific chain. This question is especially relevant for very young chains.

The easiest way to check whether certain common contracts are deployed could be to search with codeslaw.app (if the chain is supported).

@mds1 mds1 closed this as completed in #45 Sep 19, 2023
@mds1
Copy link
Owner Author

mds1 commented Sep 19, 2023

To expand on the Gnosis Safe thought, there can be questions about whether certain versions of Gnosis Safe contracts are compatible with a specific chain. This question is especially relevant for very young chains.

Do you have more info on this? I wasn't aware certain versions of Safe contracts aren't compatible on other chains. Unless you mean the Safe.sol vs. SafeL2.sol distinction

@engn33r
Copy link

engn33r commented Sep 21, 2023

I only heard about the Gnosis second hand, but there are two possible incompatibilities that come to mind:

  1. EVM-compatible chains may require modifications to contracts that are deployed to mainnet Ethereum. Such changes could theoretically impact a wide range of popular libraries and dependencies (OopenZeppelin, Gnosis, etc.). If this library has not been deployed to a new EVM-compatible chain yet, or has not had much time to be battle tested, there may be questions about compatibility. This is a general observation and not specific to Gnosis, so tracking the top-5 or top-10 common libraries might make things messy
  2. Open issues on the Safe repo show that there's work underway related to upgrading from 1.3.X to 1.4.X and beyond. The Safe frontend was using 1.3.X last I checked, which means that contracts from the 1.4.X release or newer may not be fully compatible with the Safe frontend. This means that older code should be used if frontend support is important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants